Conversation
preliminary work for adding the sentry API to the plugin
Contributor
Author
|
should work, still needs some polishing tho (e.g. setting configuration in |
mcquenji
pushed a commit
that referenced
this pull request
Oct 9, 2025
`column` seems to be a reserved keyword in postgresql. really cool that moodle never warned me of this. anyway, this should fix EDUPL-19 if I'm correct. this PR also: - reverts previous change regarding extra debugging on this DB request (it did its job and will be superseded by #89 later) - reverts workarounds I put in place precisely so that I wouldn't have to rename the field (postgres seems to have "interesting" behaviour around inserting stuff without IDs) do note that inside the code, the field in the \*model\* is still called "column" - this is on one hand for brevity, and on the other so I don't have to refactor as much.
RiedleroD
force-pushed
the
EDUPL-26-sentry-api
branch
from
9fb9987 to
a569191
Compare
Contributor
Author
|
thanks for the shitty backmerge github. real useless |
RiedleroD
force-pushed
the
EDUPL-26-sentry-api
branch
from
a569191 to
18eea0b
Compare
it's already included in moodle proper
this *should* work, but it's really hard to test, so… we'll see next release
Contributor
Author
|
this should be up & running on the testserver now. After wrestling with moodle for 2h to make it un-bricked, I'm beat. Testing this tomorrow. |
to protect from misspelling errors, and to have a semi-central place where all the keys are listed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes EDUPL-26 impl sentry API for plugin
TODO:
composer upon release